Add support for save changes async for issue #1#2
Open
togakangaroo wants to merge 13 commits intovisoft:masterfrom
Open
Add support for save changes async for issue #1#2togakangaroo wants to merge 13 commits intovisoft:masterfrom
togakangaroo wants to merge 13 commits intovisoft:masterfrom
Conversation
This reverts commit b470bac.
Author
|
I tried to rewrite it without the await keyword but that's not going to fly since the 4.0 version of EntityFramework doesn't actually have a SaveChangesAsync to overwrite. Therefore the current strategy of using the same HookedDbContext file and compiling it in two different projects fails for the 4.0 version. Possible solutions
My vote is still to drop support for old versions of .Net |
Owner
|
I'm up for dropping .NET 4 support at this point. EF6 for 4.5 is a different beast and should just be rewritten as a 4.5 assembly. For legacy support, users can keep using the current version for those using EF6 with .NET 4. I haven't had a chance to review your code, but I think we can probably do a bunch of cleanup since we won't have .NET 4 support anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what to do with EfHooks/EfHooks.Test (the non .Net 4.5 version). Since < 4.5 doesn't support the async keyword that project no longer compiles
Issue #1